Cover Detail
Show a cover letter.
GET /api/covers/112654/?format=api
{ "id": 112654, "url": "http://patches.dpdk.org/api/covers/112654/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20220610142406.580943-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220610142406.580943-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220610142406.580943-1-bruce.richardson@intel.com", "date": "2022-06-10T14:24:04", "name": "[v3,0/2] fix uncallable unit tests (Bugzilla 1002)", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20220610142406.580943-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 23469, "url": "http://patches.dpdk.org/api/series/23469/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23469", "date": "2022-06-10T14:24:04", "name": "fix uncallable unit tests (Bugzilla 1002)", "version": 3, "mbox": "http://patches.dpdk.org/series/23469/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/112654/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D601A0553;\n\tFri, 10 Jun 2022 16:24:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 132E34069C;\n\tFri, 10 Jun 2022 16:24:17 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id AF0C040689\n for <dev@dpdk.org>; Fri, 10 Jun 2022 16:24:15 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jun 2022 07:24:13 -0700", "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.181])\n by fmsmga002.fm.intel.com with ESMTP; 10 Jun 2022 07:24:12 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1654871055; x=1686407055;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Z/0FXQ0yVay7r/9aJRD5RbjEVRNzhq3M7IZFQBhu/Pk=;\n b=UsMA+eWfam0xmbYFfSjH5KnDNKVzfa1f9Ug4VpNbK7NfQYqmvVSvt8FH\n btv6BdaHDOXEjCg8cL97gd4bmC9Lg5A9RPtrv1BfJ5a5o/CINr4KydPMn\n HJoUXwyLzSwTM2gF8AaHSMHXuwXp4mGyaLYcgDtRaE3LKWHvzpONKY4Po\n lWaq09pawp5OGK0WizC8nTU8EDW7VZJjDICEd850EZRChUi8QBeTxSA45\n hyEEupjQ2gtDpHUHtHD+8bjGyIRG3NiNFx4eQGsCNTfOzpykghX8Y+svV\n 3RHbeHjlP8+X0m8lsvlw3ehKLkRr1HWOMcDe3UJxKmx+4qJMK7xdwP0l+ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10373\"; a=\"258079374\"", "E=Sophos;i=\"5.91,290,1647327600\"; d=\"scan'208\";a=\"258079374\"", "E=Sophos;i=\"5.91,290,1647327600\"; d=\"scan'208\";a=\"684568657\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "olivier.matz@6wind.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 0/2] fix uncallable unit tests (Bugzilla 1002)", "Date": "Fri, 10 Jun 2022 15:24:04 +0100", "Message-Id": "<20220610142406.580943-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220520145631.137962-1-bruce.richardson@intel.com>", "References": "<20220520145631.137962-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The dump* unit tests are uncallable from our test framework because the command\nvalidation in the unit test binary is incorrect. Rather than trying to fix this\ndirectly in the binary, a better approach is to add command validation to the\ncmdline library - which already has 99% of what we need already - and use that\nfrom the test app.\n\nPatch fix not CC'ed to stable, as fix requires new function in cmdline library.\n\n\nV3:\n * Fix feedback from Olivier's review\n * Fix typo in spelling of \"binary\" (binrary) in patch 2 commit log\n\nV2:\n* Fix checkpatch issues\n\nBruce Richardson (2):\n cmdline: add function to verify valid commands\n test: use cmdline library to validate args\n\n app/test/commands.c | 11 -----------\n app/test/test.c | 24 +++++++-----------------\n lib/cmdline/cmdline_parse.c | 28 ++++++++++++++++++++--------\n lib/cmdline/cmdline_parse.h | 17 +++++++++++++++--\n lib/cmdline/version.map | 3 +++\n 5 files changed, 45 insertions(+), 38 deletions(-)\n\n--\n2.34.1" }