Cover Detail
Show a cover letter.
GET /api/covers/111554/?format=api
http://patches.dpdk.org/api/covers/111554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20220520151240.139566-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520151240.139566-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520151240.139566-1-bruce.richardson@intel.com", "date": "2022-05-20T15:12:38", "name": "[v2,0/2] fix uncallable unit tests (Bugzilla 1002)", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20220520151240.139566-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 23069, "url": "http://patches.dpdk.org/api/series/23069/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23069", "date": "2022-05-20T15:12:38", "name": "fix uncallable unit tests (Bugzilla 1002)", "version": 2, "mbox": "http://patches.dpdk.org/series/23069/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/111554/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B07B7A0503;\n\tFri, 20 May 2022 17:12:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 646C340222;\n\tFri, 20 May 2022 17:12:52 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 1335C40156;\n Fri, 20 May 2022 17:12:49 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 08:12:48 -0700", "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.87])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 08:12:47 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653059570; x=1684595570;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Q2wqWdg30egDCCS5TVQth7YaObG8BnM9/8pFrgJQVTk=;\n b=dnlzs9bkSLastEU86wRsFflsUbCVMAoSO0hwS3PI3voXpS/8rMZk/5FC\n 3IJPUyHGTRUBmDWELSAU9fmO3BqOgSKpebrAZrFoOba4emFNwsxjkmxlQ\n yRJWZ7rAsoHO39DhIe7NdYOih8ds2FCet3WuLQN5sDOXGRRD0dKYVqF+t\n jGr8GuPdgRflDsB++BtsqQY+TGdNtWF4iAJdnYxLSJ90IBC6dlYTFaPwN\n l2QytoULyIZcGrskDqrI1U4/ru+Y1ozRU+Nr5W6F613zllgpvwBjBLN+l\n x9ZEc45A7DxOoWzBZbESpB0Ofq7RXOnJRbCU5/EjZtrhztPFg2gZ6Qvxa A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10353\"; a=\"260216929\"", "E=Sophos;i=\"5.91,239,1647327600\"; d=\"scan'208\";a=\"260216929\"", "E=Sophos;i=\"5.91,239,1647327600\"; d=\"scan'208\";a=\"599263702\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, weiyuanx.li@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v2 0/2] fix uncallable unit tests (Bugzilla 1002)", "Date": "Fri, 20 May 2022 16:12:38 +0100", "Message-Id": "<20220520151240.139566-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220520145631.137962-1-bruce.richardson@intel.com>", "References": "<20220520145631.137962-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The dump* unit tests are uncallable from our test framework because the command\nvalidation in the unit test binary is incorrect. Rather than trying to fix this\ndirectly in the binary, a better approach is to add command validation to the\ncmdline library - which already has 99% of what we need already - and use that\nfrom the test app.\n\nV2:\n* Fix checkpatch issues\n\nBruce Richardson (2):\n cmdline: add function to verify valid commands\n test: use cmdline library to validate args\n\n app/test/commands.c | 11 -----------\n app/test/test.c | 24 +++++++-----------------\n lib/cmdline/cmdline_parse.c | 20 +++++++++++++++++---\n lib/cmdline/cmdline_parse.h | 17 +++++++++++++++--\n lib/cmdline/version.map | 3 +++\n 5 files changed, 42 insertions(+), 33 deletions(-)\n\n--\n2.34.1" }{ "id": 111554, "url": "