Cover Detail
Show a cover letter.
GET /api/covers/107271/?format=api
http://patches.dpdk.org/api/covers/107271/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20220210154239.587185-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220210154239.587185-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220210154239.587185-1-bruce.richardson@intel.com", "date": "2022-02-10T15:42:32", "name": "[v4,0/7] Verify C++ compatibility of public headers", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20220210154239.587185-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21607, "url": "http://patches.dpdk.org/api/series/21607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21607", "date": "2022-02-10T15:42:32", "name": "Verify C++ compatibility of public headers", "version": 4, "mbox": "http://patches.dpdk.org/series/21607/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/107271/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7961CA00BE;\n\tThu, 10 Feb 2022 16:42:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06228426EE;\n\tThu, 10 Feb 2022 16:42:48 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id BD0ED426ED\n for <dev@dpdk.org>; Thu, 10 Feb 2022 16:42:46 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2022 07:42:44 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by orsmga006.jf.intel.com with ESMTP; 10 Feb 2022 07:42:43 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644507766; x=1676043766;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=x5nzhG8Mv7bqLZbnBmhIP/fKaEDy8ajxi2BSN7zjsM4=;\n b=DjmgYcvLoDay7OXTJmj1rEo6J3HUnW44ApDrYuev9zwiRSN80P57p9gd\n KnvsKCt9oHYRRJ/uW3biEbEtu2D+f3yAWeZqdnKLPPKHmCH+5bzHTNZG/\n KI11DV54JVwTUKssdFcYBTibOoLTkdXOGWpP9uLhl1VSLmLAShGrjwgxH\n dbLcgJ9AVgxtIddmBIKUHPt2ZMazv3576XxhV/P9ZUr9AURcOrv3+aI4l\n wNBS64eeqrz5Ne02mu2qIcUUId94PTuZ0Ea2RexIIzppx23xHwhrn7/pf\n tyqrBkI8dlmHe1HOHzxjMcZJBFZtMX4JOKiWgV/l6jfEZpmSZ/3zH0q/U A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10254\"; a=\"249723474\"", "E=Sophos;i=\"5.88,359,1635231600\"; d=\"scan'208\";a=\"249723474\"", "E=Sophos;i=\"5.88,359,1635231600\"; d=\"scan'208\";a=\"485723347\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v4 0/7] Verify C++ compatibility of public headers", "Date": "Thu, 10 Feb 2022 15:42:32 +0000", "Message-Id": "<20220210154239.587185-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220204174209.440207-1-bruce.richardson@intel.com>", "References": "<20220204174209.440207-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset expands upon the exiting chkincs infrastructure to build a\nC++ test application as well as the existing C test app, which helps\ncatch any build errors when the public DPDK headers are included in C++\ncode. The rest of this patchset fixes the errors caught by this\nadditional check - mostly missing casts, but also one use of \"new\" as a\nvariable name, and one missing closing brace for an 'extern \"C\"' block.\n\nV4:\n* add g++-multilib to packages to install for github checks to ensure 32-bit\n builds work\n* correct the fixline for patch 1\n* add extra cpp_args and cpp_link_args for 32-bit builds in test-meson-builds\n so that includes checks can pass there if enabled.\n\nV3:\n* update linux-build script to have cpp_args=-m32 for 32-bit builds\n\nV2:\n* Changed patch 6 to have a minimally-invasive fix for C++ without\n affecting existing C code.\n* Added fixlines and Cc stable for all patches which are fixes\n *** SUBJECT HERE ***\n\n*** BLURB HERE ***\n\nBruce Richardson (7):\n eal: fix header build with C++\n eventdev: fix header build with C++\n graph: fix missing explicit cast for C++ build\n ipsec: fix missing explicit cast for C++ build\n table: fix missing explicit casts for C++ build\n vhost: fix incompatible header includes for C++\n buildtools/chkincs: test headers for C++ compatibility\n\n .ci/linux-build.sh | 1 +\n .github/workflows/build.yml | 2 +-\n buildtools/chkincs/main.cpp | 4 +++\n buildtools/chkincs/meson.build | 20 +++++++++++++++\n devtools/test-meson-builds.sh | 3 ++-\n lib/eal/include/generic/rte_ticketlock.h | 14 +++++------\n lib/eal/include/rte_trace_point.h | 2 +-\n lib/eventdev/rte_event_timer_adapter.h | 3 +++\n lib/eventdev/rte_eventdev.h | 2 +-\n lib/graph/rte_graph_worker.h | 2 +-\n lib/ipsec/rte_ipsec_group.h | 4 +--\n lib/table/rte_table_hash_func.h | 32 ++++++++++++------------\n lib/vhost/rte_vhost.h | 2 ++\n 13 files changed, 61 insertions(+), 30 deletions(-)\n create mode 100644 buildtools/chkincs/main.cpp\n\n--\n2.32.0" }{ "id": 107271, "url": "