Cover Detail
Show a cover letter.
GET /api/covers/106853/?format=api
{ "id": 106853, "url": "http://patches.dpdk.org/api/covers/106853/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20220204174209.440207-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220204174209.440207-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220204174209.440207-1-bruce.richardson@intel.com", "date": "2022-02-04T17:42:02", "name": "[0/7] Verify C++ compatibility of public headers", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20220204174209.440207-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21466, "url": "http://patches.dpdk.org/api/series/21466/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21466", "date": "2022-02-04T17:42:02", "name": "Verify C++ compatibility of public headers", "version": 1, "mbox": "http://patches.dpdk.org/series/21466/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/106853/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05511A0350;\n\tFri, 4 Feb 2022 18:42:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 91A024013F;\n\tFri, 4 Feb 2022 18:42:19 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 176EC40041\n for <dev@dpdk.org>; Fri, 4 Feb 2022 18:42:17 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Feb 2022 09:42:17 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.162])\n by FMSMGA003.fm.intel.com with ESMTP; 04 Feb 2022 09:42:16 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643996538; x=1675532538;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=98ircbt3+u79Z8Li4WZela75IfeuLrKA+DfXcoRxgHw=;\n b=RXZ3bLl1cZpjYpiHZ9S95haJCA1wzMTGwH0ig0d4pyEfGjsUALcUydcL\n hNw3XrZZ14wOCtfYtJC0xwlj+cHQdGtg5taCDvT0lq1NGBaXlz8RjjAal\n B+3tO4Lim2DcNXyRut6Ffsox9ic7DugzN5RkxhaqH3lChLSXfVbuB/m3+\n nRMdrgdYpwf7P1isKBGsoVy4Pi60UHhHGp9Tucs0oO1UHyhe6Dzf/59V2\n oOPQe8o4ygkBBYyQP1DCtDWFtha/X/9fnPTowBEtFkRzMUaOejgr6Xa7h\n RoNCmPu9s5JggNiKUx3CnN4Ut0QzrJToXeAFf4kG+aj3ZMXlLB8KTDqVq A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10248\"; a=\"229060464\"", "E=Sophos;i=\"5.88,343,1635231600\"; d=\"scan'208\";a=\"229060464\"", "E=Sophos;i=\"5.88,343,1635231600\"; d=\"scan'208\";a=\"620890196\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 0/7] Verify C++ compatibility of public headers", "Date": "Fri, 4 Feb 2022 17:42:02 +0000", "Message-Id": "<20220204174209.440207-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patchset expands upon the exiting chkincs infrastructure to build a\nC++ test application as well as the existing C test app, which helps\ncatch any build errors when the public DPDK headers are included in C++\ncode. The rest of this patchset fixes the errors caught by this\nadditional check - mostly missing casts, but also one use of \"new\" as a\nvariable name, and one missing closing brace for an 'extern \"C\"' block.\n\nNOTE: the most complicated changes are in the 6th patch, where there\nwere linux headers included which were not C++ compatible. This patch\nmoves the inclusion of those headers to non-public locations in the code\nto remove those issues, but I am uncertain what the knock-on impacts of\nthis change may be. Therefore, I ask particular review from vhost/vdpa\nmaintainers to see if there is a better solution to this issue\n\nBruce Richardson (7):\n eal: fix header build with C++\n eventdev: fix header build with C++\n graph: add explicit cast to allow C++ build\n ipsec: : add explicit cast to allow C++ build\n table: add explicit casts for C++ compatibility\n vhost: remove non-C++ compatible includes\n buildtools/chkincs: test headers for C++ compatibility\n\n buildtools/chkincs/main.cpp | 4 +++\n buildtools/chkincs/meson.build | 20 +++++++++++++++\n drivers/net/vhost/rte_eth_vhost.c | 2 ++\n drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++\n drivers/vdpa/mlx5/mlx5_vdpa.h | 1 +\n lib/eal/include/generic/rte_ticketlock.h | 14 +++++------\n lib/eal/include/rte_trace_point.h | 2 +-\n lib/eventdev/rte_event_timer_adapter.h | 3 +++\n lib/eventdev/rte_eventdev.h | 2 +-\n lib/graph/rte_graph_worker.h | 2 +-\n lib/ipsec/rte_ipsec_group.h | 4 +--\n lib/table/rte_table_hash_func.h | 32 ++++++++++++------------\n lib/vhost/rte_vhost.h | 4 ---\n 13 files changed, 60 insertions(+), 32 deletions(-)\n create mode 100644 buildtools/chkincs/main.cpp\n\n--\n2.32.0" }